From 052f587d000cb0bf6890ef1d06d87718c8c0f6f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20Cornell=C3=A0?= Date: Thu, 28 May 2026 20:04:46 +0200 Subject: [PATCH] fix(dotenv): apply review suggestions --- plugins/dotenv/dotenv.plugin.zsh | 2 +- plugins/dotenv/tests/_support/bootstrap | 2 +- plugins/dotenv/tests/basic-parsing.zunit | 10 ++++++++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/plugins/dotenv/dotenv.plugin.zsh b/plugins/dotenv/dotenv.plugin.zsh index ccafad208..72839a501 100644 --- a/plugins/dotenv/dotenv.plugin.zsh +++ b/plugins/dotenv/dotenv.plugin.zsh @@ -55,7 +55,7 @@ _parse_dotenv_content() { fi [[ -z "$line" ]] || line+=" " - line="$node" + line+="$node" done local -a forbidden_vars=( diff --git a/plugins/dotenv/tests/_support/bootstrap b/plugins/dotenv/tests/_support/bootstrap index 495c9bd23..f45bec020 100644 --- a/plugins/dotenv/tests/_support/bootstrap +++ b/plugins/dotenv/tests/_support/bootstrap @@ -23,7 +23,7 @@ _parse_dotenv_export() { done } -# Helper: Run parse_dotenv supressing stderr +# Helper: Run parse_dotenv suppressing stderr _parse_dotenv_quiet() { parse_dotenv "$@" 2>/dev/null } diff --git a/plugins/dotenv/tests/basic-parsing.zunit b/plugins/dotenv/tests/basic-parsing.zunit index ef899f706..611f6a70a 100644 --- a/plugins/dotenv/tests/basic-parsing.zunit +++ b/plugins/dotenv/tests/basic-parsing.zunit @@ -250,6 +250,16 @@ EOF assert "DOTENV_TEST_VARS" var_same_as "expected_vars" } +@test 'parse ignores non-assignment commands with assignment-looking arguments' { + > "$fixture" <<'EOF' +print SHOULD_NOT_PARSE=value +EOF + + _parse_dotenv_test "$fixture" + + assert "DOTENV_TEST_VARS" var_same_as "expected_vars" +} + @test 'parse special characters' { > "$fixture" <<'EOF' # Special characters